Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> I'll do that. I'm using to many BUG_ON in this code.
> 
> > > +        {
> > > +            BUG_ON(!modlist[i].paddr || modlist[i].paddr > UINT_MAX ||
> > > +                   modlist[i].size > UINT_MAX);
> > 
> > To be fair all of those values are in spec..Perhaps you should mention
> > that the libxc code would never put those there and neermind the spec?
> 
> Yes, there is just this mention in the spec: "However Xen will always try
> to place all modules below the 4GiB boundary."
> 
> But it actualy would be a bug if the blob would be abrove 4GiB, since
> hvmloader can not read that far, right? I can add a comment.

Well no. It says that the hypervisor will 'try', not that it 'MUST'.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel