Re: [Xen-devel] [PATCH v4 09/14] hvmloader: Check modules whereabouts in perform_tests

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Mar 15, 2016 at 09:23:37PM -0400, Konrad Rzeszutek Wilk wrote:
> On Mon, Mar 14, 2016 at 05:55:44PM +0000, Anthony PERARD wrote:
> > As perform_tests() is going to clear memory past 4MB, we check that the
> > memory can be use or we skip the tests.
> 
> I get the reason you want this - but if we have giant binary blobs
> and something else screws up what the tests are testing for- we
> don't have a regression test anymore.
> 
> .. Oh my looking at rep_io_test and trying to make it more dynamic
> is tricky but should be managable?

Maybe, it have been mention that the tests could be more dynamic. But
they could also be moved to Andrew's Xen Test Framework.

For now, the test are unlikely to be skipped. On my system, in the worse
case, with rombios compiled in, and trying to boot with ovmf, the test are
not skiped. So with seabios it should be fine for some time.

Still, I'm not sure what to do about it.

> I presume that is the test that blows everything out of the sky?

Yes, the test.

> And also the placement of the page tables?

:(, I did not take the page tables into account will writing the check.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel