Re: [Xen-devel] [PATCH v3 02/28] xen/x86: Rename features to be closer to the vendor definitions

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/03/16 08:01, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 15, 2016 at 03:34:58PM +0000, Andrew Cooper wrote:
>> These features are soon to be exposed in the Xen public API.  Rename them to
>> better match the vendor definitions.
>>
> At the same time they won't match with Linux definitions - which is convient
> to lookup what those flags do. Perhaps add a comment for the define
> mentioning the old name?.
>
> That is Linux uses these - MWAIT, EST, HT, ACC
>
> The VMX and VMX changes are inline with Linux (that is your change matches
> up with what Linux has).
>
> I couldn't find X86_FEATURE_PQM or CAT in Linux upstream so no clue
> what they will be called.

This was requested specifically by Jan, based on v2.  The idea is to use
feature names as specified in the architecture manual.

This patch originally also contained the renaming in c/s dc88221c97, but
that dropped out during rebase.

PQM is Platform QoS Monitoring, as specified in the Intel manual.  PQE
is Platform QoS Enforcement, (formally cat).

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel