Re: [Xen-devel] [PATCH v8 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On March 29, 2016 10:21pm, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> On Tue, Mar 29, 2016 at 01:32:02AM +0000, Xu, Quan wrote:
> > On March 28, 2016 10:11pm, Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx> wrote:
> > > >
> > > > > > +            list_del(&pdev->domain_list);
> > > > > > +            pdev->domain = NULL;
> > > > > > +            pci_hide_existing_device(pdev);
> > > > > > +            break;
> > > > > > +        }
> > > > > > +    }
> > > > > > +
> > > > > > +    pcidevs_unlock();
> > > > > > +
> > > > > > +    if ( !is_hardware_domain(d) )
> > > > > > +        domain_crash(d);
> > > > >
> > > > > The description said something about 'just throw out a warning'
> > > > > (if the domain owning it is a hardware domain). That seems to be
> missing?
> > > > >
> > > > >
> > > >
> > > > The warning is in the call path, in queue_invalidate_wait():
> > > >   """Queue invalidate wait descriptor timed out."""
> > >
> > > Aah, right.
> > > >
> > > > Then, does it make sense?
> > >
> > > Yes. I would recommend you modify the commit description so that
> > > clueless folks like me can see it. You could modify the commit 
> > > description to
> say:
> > >
> > > "just throw out a warning (done in queue_invalidate_wait)."
> > >
> > >
> >
> > Then, based on Dario/your suggestion, the changelog could be:
> > """
> > VT-d: Fix vt-d Device-TLB flush timeout issue
> >
> > If Device-TLB flush timed out, we would hide the target ATS device and crash
> the domain owning this ATS device.
> > If impacted domain is hardware domain, just throw out a warning (done in
> queue_invalidate_wait).
> >
> > By hiding the device, we make sure it can't be assigned to any domain any
> longer.
> > """
> 
> s/to any domain any longer./to any domain any longer (see device_assigned)./
> 
Got it, thanks.

Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel