[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing
On Wed, Mar 30, 2016 at 04:46:58PM +0100, Jonathan Davies wrote: [...] > > >> Andrew's guess was close, but the wrong way around -- please could you > > >> try the > > >> following with the older compiler? > > >> > > >> let req = {Packet.tid=tid; Packet.rid=rid; Packet.ty=ty; > > >> Packet.data=data} in > > >> > > >> I was using a syntactic feature of OCaml called 'field punning' which is > > >> generally considered good practice and makes for more readable code. It > > >> looks > > >> like this feature was introduced in OCaml 3.12.0 (dating from 2010), > > >> which is > > >> consistent with Boris' findings. > > >> > > >> What's the policy here -- is there a defined version of the OCaml > > >> compiler which > > >> tools/ocaml needs to be able to compile with? > > > > > > It is not explicitly listed in README or INSTALL. The ocaml tools > > > maintainer (Dave in this case) is welcome to provide the minimum version > > > required. > > > > > > Meanwhile, I don't think we should break existing build without pinning > > > down the minimum required version first, so we should fix Boris's > > > breakage. The fix seems simple enough anyway. > > > > It looks like the fix is small and easy — I think this is good for now. > > > > Let’s postpone requiring a later OCaml version until we really need a > > feature only present in a later version. I suspect this will happen > > eventually, probably when we try to add a dependency (e.g. from the Mirage > > world) which requires 4.02+. > > OK; sounds sensible. > > Since the original patch has already been committed to staging, I presume > you'd > like me to formally submit a standalone patch that fixes this issue. I will > post > it separately. > Yes, a standalone patch to fix the issue is fine. Wei. > If I'm wrong and you'd like me to post a v2 of the whole series, let me know. > > Thanks, > Jonathan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |