Re: [Xen-devel] [PATCH v5 12/28] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

[Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>]

On Fri, Apr 01, 2016 at 07:33:54AM -0600, Jan Beulich wrote:
> >>> On 24.03.16 at 21:00, <konrad.wilk@xxxxxxxxxx> wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -75,6 +75,7 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
> >                     echo 'EFI installation only partially done (EFI_VENDOR 
> > not set)' >&2; \
> >             fi; \
> >     fi
> > +   $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) install
> >  
> >  .PHONY: _uninstall
> >  _uninstall: D=$(DESTDIR)
> > @@ -92,6 +93,7 @@ _uninstall:
> >     rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi
> >     rm -f $(D)$(EFI_DIR)/$(T).efi
> >     rm -f 
> > $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi
> > +   $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) uninstall
> 
> Pretty certainly stray changes, or they'd need a really good
> explanation.

It is used to remove the test-cases. Perhaps it should be called
'uninstall-tests' ? I will skip this for right now - and figure out
later how to make the OSSTest harvest these.

> 
> > --- a/xen/arch/x86/Makefile
> > +++ b/xen/arch/x86/Makefile
> > @@ -75,7 +75,12 @@ efi-y := $(shell if [ ! -r 
> > $(BASEDIR)/include/xen/compile.h -o \
> >  $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
> >     ./boot/mkelf32 $(TARGET)-syms $(TARGET) 0x100000 \
> >     `$(NM) -nr $(TARGET)-syms | head -n 1 | sed -e 's/^\([^ ]*\).*/0x\1/'`
> > +   $(MAKE) -f $(BASEDIR)/Rules.mk -C test
> >  
> > +install:
> > +   $(MAKE) -f $(BASEDIR)/Rules.mk -C test install
> > +uninstall:
> > +   $(MAKE) -f $(BASEDIR)/Rules.mk -C test uninstall
> 
> Tests or examples should not be built by default.


I can certainly make a seperate top destination called 'test' that will
take care of this? Or should it be called 'xsplice' ? 'xsplice-test' ?


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel