[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 09/10] libxl: Fix libxl_set_memory_target return value

On 4 April 2016 at 12:40, George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
> On 01/04/16 15:55, Roger Pau Monné wrote:
> > On Fri, 1 Apr 2016, Paulina Szubarczyk wrote:
> >> libxl_set_memory_target seems to have the following return values:
> >>
> >> * 1 on failure, if the failure happens because of a xenstore error *or*
> >> * invalid
> >> target
> >
> > AFAICT it seems like you haven't touched this patch at all, but the commit
> > message looks messed up (at least there's an extra "\n" here).
> >
> > Also, I'm not a git expert, but I think if the patch is from George, and
> > you haven't touched it, it should contain an extra "From:" field in
> > the message body with George's address.
> I'm not sure the "From" thing is really worth a re-send, but since she's
> re-sending it anyway, you might as well. :-)
>  -George

I have found the previous thread concerning this patch
where Ian asked for a change from 'r' to 'lrc' as a return value of
libxl__fill_dom0_memory_info, so I will modify it before resend.

There is also proposition of improvement of the modified function but maybe
it will be better to make the changes in different path.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.