Re: [Xen-devel] [RFC PATCH 2/2] build: convert crash_debug to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.03.16 at 22:02, <cardoe@xxxxxxxxxx> wrote:
> On 3/25/16 2:49 PM, Konrad Rzeszutek Wilk wrote:
>> On Thu, Mar 24, 2016 at 11:48:19AM -0500, Doug Goldstein wrote:
>>> --- a/xen/Kconfig.debug
>>> +++ b/xen/Kconfig.debug
>>> @@ -4,3 +4,14 @@ menuconfig DEBUG
>>>     ---help---
>>>       If you want to debug Xen say Y and select any additional debugging
>>>       support options.
>>> +
>>> +if DEBUG
>> 
>> Perhaps if !defined then atuomatically enable it? Looking at Config.mk
>> it seems you could do crash_debug without debug=y?
> 
> debug=y unfortunately is more than just a "meta" option that selects
> verbose=y and frame_pointer=y. It also turns off NDEBUG so that debug
> messages appear. I'm not sure how that should be mapped in the context
> of this patch. Should the messages be enabled when DEBUG is enabled or
> should there be another option?

I think this should be each another option, defaulting in a way
matching what the current implications are. Perhaps, as elsewhere,
the prompts should again be made dependent upon EXPERT.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel