[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 04/11] xen: sched: close potential races when switching scheduler to CPUs

On Fri, Apr 08, 2016 at 03:11:23PM +0200, Dario Faggioli wrote:
> On Fri, 2016-04-08 at 14:00 +0100, George Dunlap wrote:
> > On 08/04/16 13:52, George Dunlap wrote:
> > > On 08/04/16 02:23, Dario Faggioli wrote:
> > > > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > > Thanks!
> > > 
> > > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> > Committers:
> > 
> > Hopefully the arinc653 maintainers will get an opportunity to take a
> > look at this before the hard freeze today.  But if not, given the
> > timing, and the fact that the patch is really more to do with the
> > interface to the scheduling system as a whole rather than internal
> > algorithms of the arinc scheduler, I think it's probably OK to take
> > the
> > liberty of checking it in even without an Ack (as long as there's no
> > Nack).  We can always revert / amend it later if there are
> > objections.
> > 
> Thanks George,
> FWIW, I do agree, and I'm up for fixing any issue that could be raised,
> or any bug that could surface in ARINC code because of this, super
> quickly, during the rc period.
> Now, a much easier but I guess technically relevant question: assuming
> that you (George) also like and Ack patch 8, should I (and this is for
> committers) resend the series, or do you guys can fetch it from the git
> branch and/or list (with the correct version of patch 8 being the one
> attached to the reply to Juergen's further comments)?

It is easier (at least for me) if I do less work.

That means if the patches have all the Acked-by and such without me having
to do it - then that is far easier.

And it is far easier (probably?) for you to create an branch called 
which has the patches that have been Acked- and are stripped of the ---.

So I can just do 'git pull' and all of them are in.

But other committers may prefer doing it differently (via git am or such)
in which case resending the series may be simpler?

But then today it looks like its just me and Ian doing commits - so
if you can get Wei's OK , just poke me on IRC with the branch name
and I will slurp it up.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.