Re: [Xen-devel] [PATCH] vm_event: Implement ARM SMC events

[Julien Grall <julien.grall@xxxxxxx>]

Hello Tamas,

On 12/04/2016 16:05, Tamas K Lengyel wrote:
> On Apr 11, 2016 22:31, "Jan Beulich" <jbeulich@xxxxxxxx
> <mailto:jbeulich@xxxxxxxx>> wrote:
>  >
>  > >>> Tamas K Lengyel <tamas@xxxxxxxxxxxxx
> <mailto:tamas@xxxxxxxxxxxxx>> 04/11/16 9:47 PM >>>
[...]

>  >
>  > >+    uint64_t ttbr0;
>  > >+    uint64_t ttbr1;
>  > >+    uint32_t _pad;
>  > >+};
>  >
>  > This padding field is pretty strange: Without the adjustment to pc
> there are 16
>  > 32-bit fields (not counting the padding one), so I don't see why
> padding would be
>  > needed at all. And with pc adjusted the padding field would surely
> better go
>  > ahead of the two remaining 64-bit ones.
>
> Yes, I have been shuffling this struct around and didn't check the
> layout. Will fix. I'll also try to make this struct usable for aarch64 too.
You may want to give a look to vcpu_guest_core_regs in public/arch-arm.h

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel