Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

["Yu, Zhang" <yu.c.zhang@xxxxxxxxxxxxxxx>]

On 4/19/2016 12:58 AM, Paul Durrant wrote:
> > -----Original Message-----
> > From: Xen-devel [mailto:xen-devel-bounces@xxxxxxxxxxxxx] On Behalf Of Jan
> > Beulich
> > Sent: 18 April 2016 17:47
> > To: Paul Durrant
> > Cc: Kevin Tian; Keir (Xen.org); Andrew Cooper; Tim (Xen.org); George
> > Dunlap; xen-devel@xxxxxxxxxxxxx; yu.c.zhang@xxxxxxxxxxxxxxx;
> > zhiyuan.lv@xxxxxxxxx; jun.nakajima@xxxxxxxxx
> > Subject: Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename
> > p2m_mmio_write_dm to p2m_ioreq_server
> >
> > > > > Paul Durrant <Paul.Durrant@xxxxxxxxxx> 04/18/16 6:45 PM >>>
> > > The original patch was posted before the cut-off IIRC so I'm not sure
> > > of the policy regarding freeze-exceptions.
> >    It was submitted before the feature freeze, yes, but didn't make it in by
> > code freeze. So it's my understanding that an exception would be needed.
> Ok. Thanks for the clarification. IMO getting this in is worth the freeze 
> exception... it's a shame p2m_mmio_write_dm made it into 4.6.1. It needs to go 
> before it proliferates any further.
Thanks, Paul.

So I suppose the only place we need change for this patch is
for hvmmem_type_t, which should be defined like this?

typedef enum {
    HVMMEM_ram_rw,             /* Normal read/write guest RAM */
    HVMMEM_ram_ro,             /* Read-only; writes are discarded */
    HVMMEM_mmio_dm,            /* Reads and write go to the device model */
#if __XEN_INTERFACE_VERSION__ >= 0x00040700
    HVMMEM_ioreq_server
#else
    HVMMEM_mmio_write_dm
#endif
} hvmmem_type_t;

Besides, does 4.7 still accept freeze exception? It would be great
if we can get an approval for this.

Thanks
Yu

>    Paul
>
> > Jan
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel