Re: [Xen-devel] [PATCH v8.1 18/27] xsplice: Add support for exception tables.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/14/16 12:03 AM >>>
>@@ -48,19 +49,23 @@ static void __init swap_ex(void *a, void *b, int size)
>}
>#endif
>
>-void __init sort_exception_tables(void)
>+void __INIT sort_exception_table(struct exception_table_entry *start,
>+                          struct exception_table_entry *stop)

The latter can (and hence should) be const.

>--- a/xen/arch/x86/test/xen_hello_world_func.c
>+++ b/xen/arch/x86/test/xen_hello_world_func.c
>@@ -5,9 +5,20 @@
 >
 >#include <xen/types.h>
 >
>+static unsigned long *non_canonical_addr = (unsigned long 
>*)(0xdead000000000000ULL);

Stray parentheses.

>--- a/xen/include/xen/xsplice.h
>+++ b/xen/include/xen/xsplice.h
>@@ -43,6 +43,15 @@ struct xsplice_patch_func_internal {
     >} u;
 >};
 >
>+/*
>+ * We use alternative and exception table code - which by default are __init
>+ * only, however we need them during runtime. These macros allows us to build
>+ * the image with these functions built-in. (See the #else below).
>+ */
>+#define __INITCONST
>+#define __INITDATA
>+#define __INIT

I'm generally opposed to new symbols with double underscores in front of
them. Maybe (considering the non-xSplice case) in this case they're warranted,
but I'd prefer something along the lines of Linux'es __init_or_module (without
the double underscores then of course).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel