Re: [Xen-devel] [PATCH v3 7/7] libxl: libxl_tmem functions improving coding style

[Olaf Hering <olaf@xxxxxxxxx>]

On Wed, Apr 20, Paulina Szubarczyk wrote:

> In accordance with CODING_SYTLE:
>  - Use 'r' for return values to functions whose return values are a
>    different error space (like xc_tmem_control, xc_tmem_auth)
> 
> libxc functions are supposed to, on failure, set errno and alwas return -1 
> which is the value stored in 'r', therfore use LOG() instead LOGEV() 
> with the 'r' value since the error code is always -1.

Shouldnt in this case 'LOGEV' be replaced with 'LOGE' to get errno
printed? Plain 'LOG' does not seem to print errno.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel