Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Apr 19, 2016 at 02:17:35PM -0600, Jan Beulich wrote:
> >>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/14/16 12:02 AM >>>
> >+bool_t is_patch(const void *ptr)
> >+{
> >+    struct payload *data;
> 
> You guess it: const.
> 
> >+    /*
> >+     * No locking since this list is only ever changed during apply or 
> >revert
> >+     * context.
> >+     */
> 
> What if you crash while applying or reverting a patch? Is the list update at
> least done such that the (then nested) traversal remains safe?

Yes! We only add the struct payload to this applied_list _after_ the
patching has been done.` Hence if we crashed the list would not contain the
struct payload that was patching  - but would be safe to traverse.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel