Re: [Xen-devel] [PATCH v8.1 20/27] build_id: Provide ld-embedded build-ids

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Apr 20, 2016 at 01:14:17AM -0600, Jan Beulich wrote:
> >>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/14/16 12:03 AM >>>
> >--- a/Config.mk
> >+++ b/Config.mk
> >@@ -126,6 +126,17 @@ endef
>  >check-$(gcc) = $(call cc-ver-check,CC,0x040100,"Xen requires at least 
> gcc-4.1")
>  >$(eval $(check-y))
>  >
> >+ld-ver-build-id = $(shell $(1) --build-id 2>&1 | \
> >+                                    grep -q unrecognized && echo n || echo 
> >y)
> 
> What about localized binutils?

I couldn't find the localized entries for binutils, but that may change
in the future.

Do you think it would be better to go back to the version check?

Or look at this at some pointer later - since you mentioned you were
OK with giving an Ack even as is?

> 
> >@@ -87,7 +93,8 @@ endif
>  >
>  >$(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>       >./boot/mkelf32 $(TARGET)-syms $(TARGET) 0x100000 \
> >-    `$(NM) -nr $(TARGET)-syms | head -n 1 | sed -e 's/^\([^ ]*\).*/0x\1/'`
> >+    `$(NM) -nr $(TARGET)-syms | head -n 1 | sed -e 's/^\([^ ]*\).*/0x\1/'` \
> >+    $(notes_phdrs)
>  
>  The placement makes it somewhat non-obvious that this is an option passed
> to mkelf32 - it'd probably better go on the first line.

Sure thing.
..s nip..
> >+#if defined(BUILD_ID) && !defined(EFI)
> >+/*
> >+ * What a strange section name. The reason is that on ELF builds this 
> >section
> >+ * is extracted to notes.o (which then is ingested in the EFI file). But the
> >+ * compiler may want to inject other things in the .note which we don't care
> >+ * about - hence this unique name.
> >+ */
> >+  . = ALIGN(4);
> >+  .note.gnu.build-id : {
> >+       __note_gnu_build_id_start = .;
> >+       *(.note.gnu.build-id)
> >+       __note_gnu_build_id_end = .;
> >+  } :note :text
> >+#endif
> 
> Am I misremembering that we had agreed for this to live ahead of _erodata?

No, I misremebered! Back in.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel