[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v8.1 20/27] build_id: Provide ld-embedded build-ids
>>> On 21.04.16 at 02:33, <konrad.wilk@xxxxxxxxxx> wrote: > On Wed, Apr 20, 2016 at 01:14:17AM -0600, Jan Beulich wrote: >> >>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/14/16 12:03 AM >>> >> >--- a/Config.mk >> >+++ b/Config.mk >> >@@ -126,6 +126,17 @@ endef >> >check-$(gcc) = $(call cc-ver-check,CC,0x040100,"Xen requires at least >> gcc-4.1") >> >$(eval $(check-y)) >> > >> >+ld-ver-build-id = $(shell $(1) --build-id 2>&1 | \ >> >+ grep -q unrecognized && echo n || echo >> >y) >> >> What about localized binutils? > > I couldn't find the localized entries for binutils, but that may change > in the future. > > Do you think it would be better to go back to the version check? No, definitely not. Just that you shouldn't look at textual output imo, but at the linker actually groking the option. > Or look at this at some pointer later - since you mentioned you were > OK with giving an Ack even as is? Yes, looking at this later is fine, as long as it doesn't get forgotten. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |