Re: [Xen-devel] [PATCH v2 05/11] vt-d: propagate IOMMU Device-TLB flush error up to IOMMU unmapping.

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On April 25, 2016 6:07 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >>> On 18.04.16 at 16:00, <quan.xu@xxxxxxxxx> wrote:
> > --- a/xen/drivers/passthrough/vtd/iommu.c
> > +++ b/xen/drivers/passthrough/vtd/iommu.c
> > @@ -617,11 +617,12 @@ static void intel_iommu_iotlb_flush_all(struct
> > domain
> > *d)
> >  }
> >
> >  /* clear one page's page table */
> > -static void dma_pte_clear_one(struct domain *domain, u64 addr)
> > +static int dma_pte_clear_one(struct domain *domain, u64 addr)
> 
> This, at the latest in this series, is where __must_check should come into 
> play.
> 

Agreed.
Quan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel