Re: [Xen-devel] [PATCH v9 07/27] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables lookup.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.04.16 at 17:34, <konrad.wilk@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/common/virtual_region.c
> @@ -0,0 +1,148 @@
> +/*
> + * Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved.
> + *
> + */
> +
> +#include <xen/init.h>
> +#include <xen/kernel.h>
> +#include <xen/rcupdate.h>
> +#include <xen/spinlock.h>
> +#include <xen/virtual_region.h>
> +
> +static struct virtual_region core = {
> +    .list = LIST_HEAD_INIT(core.list),
> +    .start = _stext,
> +    .end = _etext,
> +};
> +
> +/* Becomes irrelevant when __init sections are cleared. */
> +static struct virtual_region core_init __initdata = {
> +    .list = LIST_HEAD_INIT(core_init.list),
> +    .start = _sinittext,
> +    .end = _einittext,
> +};
> +
> +/*
> + * RCU locking. Additions are done either at startup (when there is only
> + * one CPU) or when all CPUs are running without IRQs.
> + *
> + * Deletions are bit tricky. We do it when xSplicing (all CPUs running
> + * without IRQs) or during bootup (when clearing the init).
> + *
> + * Hence we use list_del_rcu (which sports an memory fence) and a spinlock
> + * on deletion.
> + *
> + * All readers of virtual_region_list MUST use list list_for_each_entry_rcu.

Stray "list"?

> + *
> + */

For v8.1 I said "Stray empty comment line." And I notice there's
another one right at the top of the file.

And for v8.1 I also said "With those minor aspects taken care of,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>" which I can only repeat
now.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel