Re: [Xen-devel] [PATCH v2 09/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.04.16 at 16:14, <quan.xu@xxxxxxxxx> wrote:
> On April 25, 2016 7:53 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>> >>> On 18.04.16 at 16:00, <quan.xu@xxxxxxxxx> wrote:
>> > --- a/xen/drivers/passthrough/vtd/iommu.c
>> > +++ b/xen/drivers/passthrough/vtd/iommu.c
> 
> 
>> > -static void iommu_flush_all(void)
>> > +static int iommu_flush_all(void)
>> 
>> __must_check
>> 
> 
> The iommu_flush_all() is also called in intel_iommu_hwdom_init()  and 
> vtd_crash_shutdown().
> As we were on the same page, we can ignore the error code propagation for 
> these two call trees.

I don't know what you're referring to here with "we were on the same
page". I don't think I've ever agreed (in the context of this series) to
ignore any error returns.

Jan

> I wonder whether we really need this '__must_check' or not, furthermore, 
> print-out message
> Is pointless (at least, to me).
> 
> Jan, could I ignore this '__must_check '?
> 
> Quan




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel