Re: [Xen-devel] [PATCH for-4.7 1/4] xen: remove usage of ENODATA error code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.04.16 at 16:21, <roger.pau@xxxxxxxxxx> wrote:
> According to the POSIX standard for error codes [0], ENODATA is both
> obsolescent (so it may be removed in the future) and optional.

It being optional still doesn't preclude us using it.

> Replace it's
> usage with ENOENT, which seems like the closest match. Both FreeBSD and
> OpenBSD don't have this error code in the native errno.h headers.

There's no rule saying that Xen's errno set must match any other OS'es.
That's one of the reasons why we (finally) separated ours.

> --- a/xen/include/public/errno.h
> +++ b/xen/include/public/errno.h
> @@ -93,7 +93,6 @@ XEN_ERRNO(ENAMETOOLONG,     36)     /* File name too long */
>  XEN_ERRNO(ENOLCK,    37)     /* No record locks available */
>  XEN_ERRNO(ENOTEMPTY, 39)     /* Directory not empty */
>  XEN_ERRNO(ENOSYS,    38)     /* Function not implemented */
> -XEN_ERRNO(ENODATA,   61)     /* No data available */
>  XEN_ERRNO(ETIME,     62)     /* Timer expired */
>  XEN_ERRNO(EBADMSG,   74)     /* Not a data message */
>  XEN_ERRNO(EOVERFLOW, 75)     /* Value too large for defined data type */

And in absolutely no case can you unconditionally remove _anything_
from other than the tools-only parts of the public interface.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel