[Xen-devel] [PATCH v10 0/3] Re: VT-d Device-TLB flush issue

[Quan Xu <quan.xu@xxxxxxxxx>]

hi,

If i didn't miss something, there is still no comment for this patch set.
I think this patch set is close to being ready. I hope this patch set is still 
in your waiting-review list, but not missed.:)

Thanks in advance!!

Quan

On 22 Apr 2016, at 18:38:49 +0800, Quan Xu <quan.xu@xxxxxxxxx> wrote:
> This patches fix current timeout concern and also allow limited ATS support:
> 
> 1. Add a timeout parameter for Queued Invalidation
> 
>  The parameter 'vtd_qi_timeout' specifies the timeout of the
>  VT-d Queued Invalidation in milliseconds. By default, the
>  timeout is 1ms, which can be boot-time changed.
> 
>  Add a __must_check annotation. The followup patch titled
>  'VT-d IOTLB/Context/IEC flush issue' addresses the __mustcheck.
>  That is the other callers of this routine (two or three levels up)
>  ignore the return code. This patch does not address this but the
>  other does.
> 
> 2. Synchronize for Device-TLB flush one by one
> 
>  Today we do Device-TLB flush synchronization after issuing flush
>  requests for all ATS devices belonging to a VM. Doing so however
>  imposes a limitation, i.e. that we can not figure out which flush
>  request is blocked in the flush queue list, based on VT-d spec.
> 
>  To prepare correct Device-TLB flush timeout handling in next patch,
>  we change the behavior to synchronize for every Device-TLB flush
>  request. So the Device-TLB flush interface is changed a little bit,
>  by checking timeout within the function instead of outside of function.
> 
>  Accordingly we also do a similar change for flush interfaces of
>  IOTLB/IEC/Context, i.e. moving synchronization into the function.
>  Since there is no user of a non-synced interface, we just rename
>  existing ones with _sync suffix.
> 
> 3. Fix vt-d Device-TLB flush timeout issue
> 
>  If Device-TLB flush timed out, we hide the target ATS device
>  immediately and crash the domain owning this ATS device. If
>  impacted domain is hardware domain, just throw out a warning.
> 
>  By hiding the device, we make sure it can't be assigned to any
>  domain any longer (see device_assigned).
> 
> **NOTE**
>    This patch set should base on one prereq patch sets:
>     a). Check VT-d Device-TLB flush error.
> 
> ----
> Not covered in this series:
> 
>     a) Eliminate the panic() in IOMMU_WAIT_OP, used only in VT-d register 
> read/write.
>        Further discussion is required on whether and how to improve it.
>     b) Handle IOTLB/Context/IEC flush timeout.
> 
> --Changes in v10:
> #patch1
>    * Enhance commit message.
>    * Enhance description in docs/misc/xen-command-line.markdown
> 
> 
> #patch2
>    * Enhance commit message.
>    * Fix indentation issue.
>    * Add __must_check anotation.
>    * Remove redundant comment.
>    * leave the existing logic as - best effort invalidation even when an 
> error has occurred.
> 
> #patch3
>    * Remove stray blanks.
>    * Remove pointless local variable.
>    * Add comment.
>    * Add printk().
> 
> Quan Xu (3):
>   vt-d: add a timeout parameter for Queued Invalidation
>   vt-d: synchronize for Device-TLB flush one by one
>   vt-d: fix vt-d Device-TLB flush timeout issue
> 
>  docs/misc/xen-command-line.markdown   |  10 +++
>  xen/drivers/passthrough/pci.c         |   6 +-
>  xen/drivers/passthrough/vtd/extern.h  |   6 +-
>  xen/drivers/passthrough/vtd/qinval.c  | 141 
> ++++++++++++++++++++++++++--------
>  xen/drivers/passthrough/vtd/x86/ats.c |  11 +--
>  xen/include/xen/pci.h                 |   1 +
>  6 files changed, 134 insertions(+), 41 deletions(-)
> 
> -- 
> 1.9.1
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel