Re: [Xen-devel] [PATCH for-4.7 2/3] docs/xsplice: Fix syntax when compiling to pdf with pandoc

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, May 19, 2016 at 04:07:00PM +0100, Wei Liu wrote:
> On Thu, May 19, 2016 at 10:56:06AM -0400, Konrad Rzeszutek Wilk wrote:
> > On Thu, May 19, 2016 at 03:41:49PM +0100, Andrew Cooper wrote:
> > > On 19/05/16 15:36, Konrad Rzeszutek Wilk wrote:
> > > > On Thu, May 19, 2016 at 03:29:45PM +0100, Andrew Cooper wrote:
> > > >> Pandoc (version 1.12.4.2 from Debian Jessie) complains at the embedded 
> > > >> \n in
> > > >> the signature checking paragraph.
> > > >>
> > > >>   /usr/bin/pandoc --number-sections --toc --standalone 
> > > >> misc/xsplice.markdown
> > > >>     --output pdf/misc/xsplice.pdf
> > > >>   ! Undefined control sequence.
> > > >>   l.1085 appended\textasciitilde{}\n
> > > >>
> > > >> Surround the string in backticks to make it verbatim text.
> > > > Ok, where is that change?
> > > 
> > > > @@ -1007,46 +1007,46 @@ expecting such that it can properly do 
> > > > signature verification.
> > > >  
> > > >  The signature is based on the all of the payloads continuously laid out
> > > >  in memory. The signature is to be appended at the end of the ELF 
> > > > payload
> > > > -prefixed with the string '~Module signature appended~\n', followed by
> > > > +prefixed with the string `'~Module signature appended~\n'`, followed by
> > > >  an signature header then followed by the signature, key identifier, 
> > > > and signers
> > > >  name.
> > > 
> > > ^ Here.
> > 
> > Thank you!
> > > 
> > > >> While altering this file, strip the substantial quantity of trailing
> > > >> whitespace.
> > > > Please do not. That was added specifically there otherwise
> > > > markdown messes it up when doing HTML and the lines get mangled up.
> > > 
> > > Markdown isn't whitespace sensitive, so that really shouldn't be doing
> > > anything.  If you want a verbatim text block, indent it by 4 characters.
> > 
> > https://daringfireball.net/projects/markdown/syntax
> > 
> > "When you do want to insert a <br /> break tag using Markdown, you end a
> > line with two or more spaces, then type return."
> > 
> > But if this can be done with indenting it with 4 characters that would
> > work too.
> > 
> 
> I take it you're happy with this change? Do you want to test it and
> report back?

No, this patch as is won't do.

The
'~Module signature appended~\n',
change to
`'~Module signature appended~\n'`,

Albeit part is good!

I can respin this patch with that simple change.
> 
> Wei.
> 
> > > 
> > > ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel