Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.05.16 at 07:01, <cardoe@xxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/xen/Kconfig.debug
> @@ -0,0 +1,13 @@
> +
> +menu "Debugging Options"
> +
> +config DEBUG
> +     bool "Developer Checks"
> +     ---help---
> +       Enables developer checks such as asserts and extra printks, this
> +       option is intended for development purposes only, and not for
> +       production use.

I'm not a native speaker, but it seems to me that either this wants to
start "Enabling ..." or the first comma wants to become a stop.

> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -20,13 +20,14 @@ include $(XEN_ROOT)/Config.mk
>  ifeq ($(debug),y)

This being left in place suggests ...

>  verbose       := y
>  frame_pointer := y
> -else
> -CFLAGS += -DNDEBUG
>  endif
>  ifeq ($(perfc_arrays),y)
>  perfc := y
>  endif
>  
> +ifeq ($(origin debug),command line)
> +$(error "You must use 'make menuconfig' to enable/disable debug now.")
> +endif

... that this is at least premature. "At least" because: Didn't you or
someone else point out that this is then still used for controlling the
tool stack part of the build?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel