Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 5/23/16 7:58 AM, Jan Beulich wrote:
>>>> On 22.05.16 at 07:01, <cardoe@xxxxxxxxxx> wrote:

>>  verbose       := y
>>  frame_pointer := y
>> -else
>> -CFLAGS += -DNDEBUG
>>  endif
>>  ifeq ($(perfc_arrays),y)
>>  perfc := y
>>  endif
>>  
>> +ifeq ($(origin debug),command line)
>> +$(error "You must use 'make menuconfig' to enable/disable debug now.")
>> +endif
> 
> ... that this is at least premature. "At least" because: Didn't you or
> someone else point out that this is then still used for controlling the
> tool stack part of the build?
> 
> Jan
> 

I purposefully just check for "command line" in this case. So if someone
does "make -C xen debug=[y|n]" or "cd xen && make debug=[y|n]" then that
should be the only time they get that message.

The other cases you'll see the check is different and would catch the
debug value from the top level.

If that's not what's intended please let me know and I can strip this
bit out. You had mentioned the 'debug' option in
http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg01027.html
which is why I tried to come up with a message that I thought would be
more limited and then hopefully not premature.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel