Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 5/23/16 8:19 AM, Andrew Cooper wrote:
> On 23/05/16 13:58, Jan Beulich wrote:
>>>>> On 22.05.16 at 07:01, <cardoe@xxxxxxxxxx> wrote:
>>> --- /dev/null
>>> +++ b/xen/Kconfig.debug
>>> @@ -0,0 +1,13 @@
>>> +
>>> +menu "Debugging Options"
>>> +
>>> +config DEBUG
>>> +   bool "Developer Checks"
>>> +   ---help---
>>> +     Enables developer checks such as asserts and extra printks, this
>>> +     option is intended for development purposes only, and not for
>>> +     production use.
>> I'm not a native speaker, but it seems to me that either this wants to
>> start "Enabling ..." or the first comma wants to become a stop.
> 
> The first comma should become a full stop.
> 
> Changing Enables to Enabling still results in a particularly odd sentence.
> 
> ~Andrew
> 

Looks like I glued together a few suggestions between the different
reposts and never really read it. This is what I've got now:

If you say Y here this will enable developer checks such as asserts
and extra printks. This option is intended for development purposes
only, and not for production use.

You probably want to say 'N' here.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel