[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 1/3] x86/hvm: Add check when register io handler

On 5/23/2016 6:46 AM, Jan Beulich wrote:
On 22.05.16 at 01:42, <suravee.suthikulpanit@xxxxxxx> wrote:
--- a/xen/arch/x86/hvm/intercept.c
+++ b/xen/arch/x86/hvm/intercept.c
@@ -258,6 +258,8 @@ struct hvm_io_handler *hvm_next_io_handler(struct domain *d)
     unsigned int i = d->arch.hvm_domain.io_handler_count++;

+    ASSERT( d->arch.hvm_domain.io_handler );

Am I wrong in understanding that without patch 2 this ASSERT() will
actually trigger? In which case the patch order would be wrong (but
that could be taken care of during commit).


Right, I can fix this in V4 if we decide to change the iommu_domain_initialise() ordering.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.