[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 01/10] vt-d: fix the IOMMU flush issue

On Thursday, May 26, 2016 11:57 PM, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >>> "Xu, Quan" <quan.xu@xxxxxxxxx> 05/26/16 12:38 PM >>>
> >On May 25, 2016 4:30 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >> The patch getting too large is easy to deal with: Split it at a
> >> reasonable boundary.
> >I recall your suggestion: top one first, then low level one..
> >I am better not to make this patch as a first one, as this is really a low 
> >level
> one.
> >Then, I need to change condition from 'if ( !rc )'  to ' if ( rc < 0 )'
> >in my series. (but if this series would be merged together, I don't need to
> think about it.) Does it make sense?
> I'm afraid I'm lacking context.

when the propagation value is positive, this patch fixes this flush issue
as follows:
  - call iommu_flush_write_buffer() to flush cache.
  - return zero.

So the condition can be 'if( rc )' for error, but if this patch is not a first 
one in series,
I need to change condition from 'if ( rc )'  to ' if ( rc < 0 )'.. as the 
propagation value may be positive..


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.