Re: [Xen-devel] [PATCH for 4.7] xen: Rename of xSplice to livepatch.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.06.16 at 02:14, <konrad.wilk@xxxxxxxxxx> wrote:
> Specifically:
> 
> s/\.xsplice/\.xlivepatch/
> s/XSPLICE_OP/LIVEPATCH_OP/
> s/XSPLICE/LIVE_PATCH/

I agree with Andrew that for consistency there should never be an
underscore between "live" and "patch", no matter what case both
parts are in. Apart from consistency this also reduces symbol name
length growth.

> s/xsplice/livepatch/
> s/livepatch_patch_func/livepatch_func/
> s/xSplice/Xen Live Patching/

As already mentioned in the earlier discussion, the patters above do
not match up with e.g. arch_livepatching_enter() - I think the "ing"
would better be dropped.

>  rename docs/misc/{xsplice.markdown => livepatch.markdown} (87%)
>  rename tools/misc/{xen-xsplice.c => xen-livepatch.c} (86%)
>  create mode 100644 xen/arch/arm/livepatch.c
>  delete mode 100644 xen/arch/arm/xsplice.c
>  rename xen/arch/x86/{xsplice.c => livepatch.c} (74%)
>  rename xen/common/{xsplice.c => livepatch.c} (75%)
>  rename xen/common/{xsplice_elf.c => livepatch_elf.c} (72%)
>  create mode 100644 xen/include/xen/livepatch.h
>  rename xen/include/xen/{xsplice_elf.h => livepatch_elf.h} (56%)
>  delete mode 100644 xen/include/xen/xsplice.h

Could you fiddle with the thresholds so that all renames actually
get reflected as such? Perhaps, as I think you had suggested
elsewhere, separating file name changes from symbols names
ones would eliminate that issue altogether.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel