Re: [Xen-devel] [PATCH 2/6] xen/build: Use the system stdarg.h header

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.06.16 at 13:24, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/include/xen/types.h
> +++ b/xen/include/xen/types.h
> @@ -1,6 +1,9 @@
>  #ifndef __TYPES_H__
>  #define __TYPES_H__
>  
> +/* Use the C freestanding headers. */
> +#include <stdarg.h>

I don't view it as good practice to include headers that aren't really
needed: Why would basically every translation unit pay the (however
small) price of this getting read and parsed? And the description of
the patch also doesn't justify this additional change in any way.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel