Re: [Xen-devel] [PATCH v3 01/17] libxl/arm: Factor out codes for generating DTB

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 07, 2016 at 12:12:48PM -0400, Boris Ostrovsky wrote:
> On 07/07/2016 12:06 PM, Julien Grall wrote:
> >
> >
> > On 07/07/16 16:48, Boris Ostrovsky wrote:
> >> On 07/07/2016 11:41 AM, Wei Liu wrote:
> >>> On Tue, Jul 05, 2016 at 11:12:31AM +0800, Shannon Zhao wrote:
> >>>> From: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> >>>>
> >>>> Factor out codes for generating DTB to prepare for adding ACPI tables
> >>>> generation codes.
> >>>>
> >>>> Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> >>>> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >>>> ---
> >>>>   tools/libxl/libxl_arm.c | 18 ++++++++++++------
> >>>>   1 file changed, 12 insertions(+), 6 deletions(-)
> >>>>
> >>>> diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c
> >>>> index ddd80aa..4a57dd7 100644
> >>>> --- a/tools/libxl/libxl_arm.c
> >>>> +++ b/tools/libxl/libxl_arm.c
> >>>> @@ -747,10 +747,9 @@ static int copy_partial_fdt(libxl__gc *gc,
> >>>> void *fdt, void *pfdt)
> >>>>
> >>>>   #define FDT_MAX_SIZE (1<<20)
> >>>>
> >>>> -int libxl__arch_domain_init_hw_description(libxl__gc *gc,
> >>>> -                                           libxl_domain_build_info
> >>>> *info,
> >>>> -                                          
> >>>> libxl__domain_build_state *state,
> >>>> -                                           struct xc_dom_image *dom)
> >>>> +static int libxl__prepare_dtb(libxl__gc *gc,
> >>>> libxl_domain_build_info *info,
> >>>> +                       libxl__domain_build_state *state,
> >>>> +                       struct xc_dom_image *dom)
> >>> I've queued this up for committing and will fix the indentation as I go
> >>> along.
> >>
> >>
> >> I don't think this can be ready for committing since it sits on top of
> >> my not-yet-reviewed series (which is pretty much guaranteed to require a
> >> new spin).
> >
> > This is only used by the ARM code which you don't modify. So I don't
> > see any issue to commit this patch.
> 
> I thought Wei was referring to the whole series being prepared for
> committing. If he was talking only about this patch (and possibly
> selected other patches) then yes, there is no dependency here. I know
> that further patches in this series want to see tools/libacpi, for
> example, and that is not ready.
> 

Oh yes, sure. This patch series is not yet ready to go in. :-)

I was only about to commit this first patch to reduce Shannon's patch
queue length.

> -boris
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel