[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v6 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h
On Tue, Jul 12, 2016 at 05:07:35PM +0100, Andrew Cooper wrote: > On 12/07/16 16:36, Anthony PERARD wrote: > > On Tue, Jul 12, 2016 at 04:09:59PM +0100, Andrew Cooper wrote: > >> On 12/07/16 15:42, Anthony PERARD wrote: > >>> +#ifndef __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__ > >>> +#define __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__ > >>> + > >>> +/* > >>> + * C representation of the x86/HVM start info layout. > >>> + * > >>> + * The canonical definition of this layout resides in public/xen.h, this > >> You should also move the big comment block from public/xen.h to here, > >> along with the XEN_HVM_START_MAGIC_VALUE define. > > Is it fine to move the comment and the define even if there has been one > > release of Xen with this in xen.h? > > The comment, absolutely. It is just a comment. > > The define is more tricky to argue. > > We currently expect people to copy&paste the public header files into > their own project, rather than linking to them, *and* insist on > maintaining API compatibility with further #ifdef'ary obfuscating the > structures and names. > > This status-quo is ludicrous and needs to stop. > > The chances of any out-of-tree users using XEN_HVM_START_MAGIC_VALUE is > minimal, and even if not 0, will be from their own local copy. > > The chances of anyone wanting XEN_HVM_START_MAGIC_VALUE without the rest > of this new file is 0. > > > So I am going to go out on a limb and say yes to moving the define. > Noone is going to notice or care, and we won't break anyone’s code by > doing so. Ok, I'll move everything, then. Thanks, -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |