[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] xsm: don't require configuring tools to build xen xsm blob
- To: Wei Liu <wei.liu2@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Date: Mon, 25 Jul 2016 13:57:21 -0400
- Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
- Delivery-date: Mon, 25 Jul 2016 17:58:14 +0000
- Ironport-phdr: 9a23:PxdvQBOFUJZ+Gvqwkcgl6mtUPXoX/o7sNwtQ0KIMzox0Kf7zrarrMEGX3/hxlliBBdydsKMczbSP+Pm4CCQp2tWoiDg6aptCVhsI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6kO74TNaIBjjLw09fr2zQd+KyZrunLnqqtX6WEZhvHKFe7R8LRG7/036l/I9ps9cEJs30QbDuXBSeu5blitCLFOXmAvgtI/rpMYwuwwZgf8q9tZBXKPmZOx4COUAVHV1DnoxrPHPmVGDCFHXpyhUbmJDrRdJSyzE8VmuQZrw9C/7q7BV0yiGJ8zmC7szXGLmp5dmTlrkhTkKM3Zt4GzRz8B9kq9fiBagvABkhZ7ZZpmPM/hzdb+beskVEzlvRMFUAgBIBIKxa8MjAqIuJ+9RocGpq1QCoBSkDCGwFejvzXlOnXaw0qokhbdyWTra1RAtSopd+E/fq8/4YeJLC7i4
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 07/25/2016 11:22 AM, Wei Liu wrote:
Starting from 08cffe66 ("xsm: add a default policy to .init.data") we
can attach a xsm policy blob to hypervisor. To build that policy blob
now hypervisor build system needs to enter tools directory.
The expectation for hypervisor and tools build systems is different. We
don't want xen build system to depend on configure but we want tools
build system to. That commit broke this expectation because it required
users to run configure before building hypervisor. This broke ARM build
because ARM developers normally build hypervisor and tools separately
(and possibly on different platforms). It can also break x86 if
developers don't run configure before building hypervisor with XSM on.
To fix it, move major part of tools/flask/policy/Makefile into
Makefile.common and create tools only Makefile to include that common
Makefile. Hypervisor Makefile will use Makefile.common to build xsm
policy.
Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Thanks for fixing this; I intended the build to remain separate but
never actually de-configured a build tree to test.
Using git-send-email -C would make the patch email clearer.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
