Re: [Xen-devel] [PATCH] xsm: don't require configuring tools to build xen xsm blob

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH] xsm: don't require configuring tools to build xen xsm 
blob"):
> Starting from 08cffe66 ("xsm: add a default policy to .init.data") we
> can attach a xsm policy blob to hypervisor. To build that policy blob
> now hypervisor build system needs to enter tools directory.
> 
> The expectation for hypervisor and tools build systems is different. We
> don't want xen build system to depend on configure but we want tools
> build system to. That commit broke this expectation because it required
> users to run configure before building hypervisor. This broke ARM build
> because ARM developers normally build hypervisor and tools separately
> (and possibly on different platforms). It can also break x86 if
> developers don't run configure before building hypervisor with XSM on.
> 
> To fix it, move major part of tools/flask/policy/Makefile into
> Makefile.common and create tools only Makefile to include that common
> Makefile. Hypervisor Makefile will use Makefile.common to build xsm
> policy.

Your reasoning and patch seem plausible.

I wonder if we should actally test configure-less hypervisor builds.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel