Re: [Xen-devel] [PATCH 3/4] x86emul: drop SrcInvalid

[George Dunlap <dunlapg@xxxxxxxxx>]

On Tue, Aug 16, 2016 at 2:34 PM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> On 16/08/16 12:27, Jan Beulich wrote:
>>>>> On 16.08.16 at 12:12, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 15/08/16 09:35, Jan Beulich wrote:
>>>> As of commit a800e4f611 ("x86emul: drop pointless and add useful
>>>> default cases") we no longer need the early bailing when "d == 0" (the
>>>> default cases in the main switch() statements take care of that),
>>>> removal of which renders internal_error() wrong and SrcInvalid useless.
>>> "the removal of which".
>> Is the article really necessary in that case? So far I thought I had
>> learned it's optional in such situations.
>
> The sentence sounds wrong without it.

It doesn't sound *wrong* to me without it, but it sounds better to me
with it.  (Or maybe this is a US / UK thing -- I have a hard time
telling anymore.)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel