[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 07/16] tables.h: add linker table support
- To: Kees Cook <keescook@xxxxxxxxxxxx>
- From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
- Date: Tue, 23 Aug 2016 01:53:12 +0200
- Cc: "gnomes@xxxxxxxxxxxxxxxxxxx" <gnomes@xxxxxxxxxxxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, Jiri Kosina <jkosina@xxxxxxx>, "benh@xxxxxxxxxxxxxxxxxxx" <benh@xxxxxxxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, platform-driver-x86@xxxxxxxxxxxxxxx, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, markus.heiser@xxxxxxxxxxx, sparclinux <sparclinux@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>, linux-sh <linux-sh@xxxxxxxxxxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, 조경민 <korea.drzix@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, anil.s.keshavamurthy@xxxxxxxxx, fontana@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, dvhart@xxxxxxxxxxxxx, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, David Vrabel <david.vrabel@xxxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, pali.rohar@xxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Miao Steven <realmz6@xxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, jbaron@xxxxxxxxxx, ananth@xxxxxxxxxxxxxxxxxx, Borislav Petkov <bp@xxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Michael Brown <mcb30@xxxxxxxx>, linux-kbuild <linux-kbuild@xxxxxxxxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Paul Bolle <pebolle@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, "ananth@xxxxxxxxxx" <ananth@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxxxxxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>, Michal Marek <mmarek@xxxxxxxx>, Mark Salter <msalter@xxxxxxxxxx>, mhiramat@xxxxxxxxxx, jolsa@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
- Delivery-date: Mon, 22 Aug 2016 23:53:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, Aug 19, 2016 at 03:02:07PM -0700, Kees Cook wrote:
> On Fri, Aug 19, 2016 at 2:32 PM, <mcgrof@xxxxxxxxxx> wrote:
> > diff --git a/arch/c6x/include/asm/tables.h b/arch/c6x/include/asm/tables.h
> > new file mode 100644
> > index 000000000000..09a9e31c573a
> > --- /dev/null
> > +++ b/arch/c6x/include/asm/tables.h
> > @@ -0,0 +1,26 @@
> > +#ifndef _ASM_C6X_ASM_TABLES_H
> > +#define _ASM_C6X_ASM_TABLES_H
> > +/*
> > + * Copyright (C) 2016 Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> > + *
> > + * This program is free software; you can redistribute it and/or modify it
> > + * under the terms of copyleft-next (version 0.3.1 or later) as published
> > + * at http://copyleft-next.org/.
> > + */
> > +
> > +/*
> > + * The c6x toolchain has a bug present even on gcc-6 when non-weak
> > attributes
> > + * are used and sends them to .rodata even though const data with weak
> > + * attributes are put in .const, this forces the linker to believe the
> > address
> > + * is relative relative to the a base + offset and you end up with
> > SB-relative
> > + * reloc error upon linking. Work around this by by forcing both start and
> > + * ending const RO waek linker table entry to be .const to fix this for
> > now.
>
> Type: waek -> weak
Thanks, fixed.
Luis
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
