Re: [Xen-devel] [PATCH 4/5] gcov: add option to determine gcov format

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 02, 2016 at 12:47:08PM +0100, Wei Liu wrote:
> Currently only gcc 3.4 format is supported.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Tim Deegan <tim@xxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

What should I do with this patch and the next one?

I'm fine with dropping both and replace them with a patch to
Kconfig.debug to make clear the format is currently 3.4, if people feel
strongly about that.

Wei.

> ---
>  xen/Kconfig.debug | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> index 06afd80..2366b06 100644
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -33,6 +33,19 @@ config GCOV
>         ---help---
>           Enable gcov (a test coverage program in GCC) support.
>  
> +choice
> +     prompt "Specify Gcov format"
> +     depends on GCOV
> +     ---help---
> +     The gcov format is determined by gcc version.
> +
> +config GCOV_FORMAT_3_4
> +       bool "GCC 3.4 format"
> +       ---help---
> +       Select this option to use the format specified in GCC 3.4.
> +
> +endchoice
> +
>  config LOCK_PROFILE
>       bool "Lock Profiling"
>       ---help---
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel