[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 5/9] x86/hypercall: Move the hypercall tables into C

>>> On 06.09.16 at 12:12, <andrew.cooper3@xxxxxxxxxx> wrote:
> Editing (and indeed, finding) the hypercall tables can be tricky, especially
> towards the end where .rept's are used to maintain the correct layout.
> Move this all into C, and let the compiler do the hard work.
> To do this, xen/hypercall.h and asm-x86/hypercall.h need to contain 
> prototypes
> for all the hypercalls; some were previously missing.  This in turn requires
> some shuffling of definitions and includes.
> One difference is that NULL function pointers are used instead of
> {,compat_}do_ni_hypercall(), which pv_hypercall() handles correctly.  All
> ni_hypercall() infrastructure is therefore dropped.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

But please don't commit this without also committing patch 7 in the
same batch.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.