Re: [Xen-devel] [PATCH v4 9/9] livepach: Add .livepatch.hooks functions and test-case

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 06/09/16 18:22, Konrad Rzeszutek Wilk wrote:
> On Tue, Aug 23, 2016 at 10:22:12PM -0400, Konrad Rzeszutek Wilk wrote:
>> From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>>
>> Add hook functions which run during patch apply and patch revert.
>> Hook functions are used by livepatch payloads to manipulate data
>> structures during patching, etc.
>>
>> One use case is the XSA91. As Martin mentions it:
>> "If we have shadow variables, we also need an unload hook to garbage
>> collect all the variables introduced by a hotpatch to prevent memory
>> leaks.  Potentially, we also want to pre-reserve memory for static or
>> existing dynamic objects in the load-hook instead of on the fly.
>>
>> For testing and debugging, various applications are possible.
>>
>> In general, the hooks provide flexibility when having to deal with
>> unforeseen cases, but their application should be rarely required (<
>> 10%)."
>>
>> Furthermore include a test-case for it.
>>
>> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>
> So... anybody willing to review it :-)
>
>> ---
>> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
>> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Cc: Tim Deegan <tim@xxxxxxx>
>> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
>
> In regards to this going in v4.8 my recollection is that:
>
>  George: 0
>  Andrew: +1
>  Jan: 0 (with a slight leaning towards -1)?
>
> I think that means folks are OK or 'don't care'.
>
> And the livepatch maintainers:
>  Ross: +1 (obviously since he wrote it)
>  Konrad: +1

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel