Re: [Xen-devel] [PATCH v2 1/2] xen/arm: alternative: Clean-up __apply_alternatives

[Julien Grall <julien.grall@xxxxxxx>]

Hi Konrad,

On 07/09/2016 15:13, Konrad Rzeszutek Wilk wrote:
> On Wed, Sep 07, 2016 at 01:50:43PM +0100, Julien Grall wrote:
> > diff --git a/xen/arch/arm/alternative.c b/xen/arch/arm/alternative.c
> > index 8ee5a11..0ca97b9 100644
> > --- a/xen/arch/arm/alternative.c
> > +++ b/xen/arch/arm/alternative.c
> > @@ -99,21 +99,21 @@ static int __apply_alternatives(const struct alt_region 
> > *region)
> >      const struct alt_instr *alt;
> >      const u32 *origptr, *replptr;
> >      u32 *writeptr, *writemap;
> > -    mfn_t text_mfn = _mfn(virt_to_mfn(_stext));
> > -    unsigned int text_order = get_order_from_bytes(_end - _start);
> > +    mfn_t xen_mfn = _mfn(virt_to_mfn(_start));
> > +    unsigned int xen_order = get_order_from_bytes(_end - _start);
> >
> >      printk(XENLOG_INFO "alternatives: Patching kernel code\n");
> >
> >      /*
> > -     * The text section is read-only. So re-map Xen to be able to patch
> > -     * the code.
> > +     * The text and inittext section are read-only. So re-map Xen to be
> > +     * able to patch the code.
> >       */
> > -    writemap = __vmap(&text_mfn, 1 << text_order, 1, 1, PAGE_HYPERVISOR,
> > +    writemap = __vmap(&xen_mfn, 1 << xen_order, 1, 1, PAGE_HYPERVISOR,
> Do you want to make it 1U? (You pointed that out in my patchset so perhaps you
> want it here?)
Good point, I used 1U whilst moving the code in patch #2 but forgot here.

I will update the patch and resend it.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel