Re: [Xen-devel] [PATCH v3 01/18] arm/x86: Add HAS_[ALTERNATIVE|EX_TABLE]

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.16 at 22:35, <konrad.wilk@xxxxxxxxxx> wrote:
> x86 implements all of them by default - and we just
> add two extra HAS_ variables to be declared in autoconf.h.
> 
> ARM 64 only has alternative while ARM 32 has none of them.
> The ARM64 is going to be a bit funny as there is an
> ALTERNATIVE already and we end up selecting the HAS_ALTERNATIVE
> whenever the ALTERNATIVE is selected.

How about replacing ALTERNATIVE by HAS_ALTERNATIVE?

> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -45,8 +45,12 @@ config ACPI
>  config HAS_GICV3
>       bool
>  
> +config HAS_ALTERNATIVE
> +     bool

This needlessly repeats what you add to common/Kconfig.

> @@ -22,6 +24,7 @@ config X86
>       select NUMA
>       select VGA
>  
> +
>  config ARCH_DEFCONFIG

Please don't.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel