Re: [Xen-devel] [PATCH v4 04/21] acpi/hvmloader: Collect processor and NUMA info in hvmloader

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.09.16 at 02:19, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/tools/firmware/hvmloader/util.h
> +++ b/tools/firmware/hvmloader/util.h
> @@ -47,7 +47,7 @@ void __bug(char *file, int line) __attribute__((noreturn));
>  #define max_t(type,x,y) \
>          ({ type __x = (x); type __y = (y); __x > __y ? __x: __y; })
>  
> -static inline int test_bit(unsigned int b, void *p)
> +static inline int test_bit(unsigned int b, const void *p)
>  {
>      return !!(((uint8_t *)p)[b>>3] & (1u<<(b&7)));

But then please also avoid casting away constness here. With that
corrected,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel