Re: [Xen-devel] [PATCH v4 10/21] acpi/hvmloader: Link ACPI object files directly

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.09.16 at 02:19, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/.gitignore
> +++ b/.gitignore
> @@ -127,13 +127,13 @@ tools/firmware/*bios/*bios*.txt
>  tools/firmware/etherboot/gpxe/*
>  tools/firmware/extboot/extboot.img
>  tools/firmware/extboot/signrom
> -tools/firmware/hvmloader/acpi/mk_dsdt
> -tools/firmware/hvmloader/acpi/dsdt*.c
> -tools/firmware/hvmloader/acpi/dsdt_*cpu*.asl
> -tools/firmware/hvmloader/acpi/ssdt_*.h
> +tools/firmware/hvmloader/dsdt*.c
> +tools/firmware/hvmloader/dsdt_*.asl

Aren't you wrongly dropping the *cpu part here?

> --- a/tools/firmware/hvmloader/acpi/Makefile
> +++ b/tools/firmware/hvmloader/acpi/Makefile
> @@ -15,41 +15,45 @@
>  XEN_ROOT = $(CURDIR)/../../../..
>  include $(XEN_ROOT)/tools/firmware/Rules.mk
>  
> -C_SRC-$(GPL)         = build.c dsdt_anycpu.c dsdt_15cpu.c 
> dsdt_anycpu_qemu_xen.c
> -C_SRC                = build.c static_tables.c $(C_SRC-y)
> -OBJS  = $(patsubst %.c,%.o,$(C_SRC))
> +# Used as a workaround for a bug in some older iasl versions where
> +# the tool will ignore everything after last '.' in the path ('-p' argument)
> +TMP_SUFFIX   = tmp__

Hmm, the comment leaves open what newer iasl does? I suppose it
strips everything after the last . too, but only if that ones comes
after the last path separator? It took me a moment to understand
that no file with this suffix will ever be created, if my above summary
is right. Please clarify this in the comment.

With these two minor issues addressed,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel