[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 02/14] x86: properly calculate xen ELF end of image address

>>> On 23.09.16 at 23:47, <daniel.kiper@xxxxxxxxxx> wrote:
> Currently xen ELF end of image address is calculated using first line from
> "nm -nr xen/xen-syms" output. However, sometimes it may contain random
> symbol address not related to the end of image in any way.

There's nothing random here, or at least you fail to demonstrate that
there is (or might be). As said before - please don't describe an issue
you think needs fixing in a tendentious way.

> It can happen
> if a symbol is introduced with address larger than __end_of_image__ symbol
> address. Such situation encountered when I linked xen ELF binary with
> xen/arch/x86/efi/relocs-dummy.S. Then first line from "nm -nr xen/xen-syms"
> contained "ffff82d0c0000000 A ALT_START" and xen ELF image memory size
> was silently set to 1023 MiB.

What you really mean to say here is that this change is a prereq for
a later one.

> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -91,7 +91,7 @@ endif
>  $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>       ./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TARGET) 0x100000 \
> -     `$(NM) -nr $(TARGET)-syms | head -n 1 | sed -e 's/^\([^ ]*\).*/0x\1/'`
> +             `$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . 
> __end_of_image__$$/0x\1/p'`

I think it was Konrad who did already point out the bogus tab here.
I'm not against you adding some indentation, but then please do so
using spaces, such that the command line argument here aligns with
the first one on the previous line.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.