[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 02/14] x86: properly calculate xen ELF end of image address

>>> On 26.09.16 at 14:06, <daniel.kiper@xxxxxxxxxx> wrote:
> On Mon, Sep 26, 2016 at 04:45:25AM -0600, Jan Beulich wrote:
>> >>> On 23.09.16 at 23:47, <daniel.kiper@xxxxxxxxxx> wrote:
>> > Currently xen ELF end of image address is calculated using first line from
>> > "nm -nr xen/xen-syms" output. However, sometimes it may contain random
>> > symbol address not related to the end of image in any way.
>> There's nothing random here, or at least you fail to demonstrate that
>> there is (or might be). As said before - please don't describe an issue
>> you think needs fixing in a tendentious way.
> OK, maybe I should say that something which is not valid end of image 
> address, e.g.:
> "However, sometimes it may contain symbol address not related to the end
> of image in any way." Is it OK for you?

Not really - "sometimes" still suggests that there is an active problem
even before this patch in some configurations or setups.

>> > It can happen
>> > if a symbol is introduced with address larger than __end_of_image__ symbol
>> > address. Such situation encountered when I linked xen ELF binary with
>> > xen/arch/x86/efi/relocs-dummy.S. Then first line from "nm -nr xen/xen-syms"
>> > contained "ffff82d0c0000000 A ALT_START" and xen ELF image memory size
>> > was silently set to 1023 MiB.
>> What you really mean to say here is that this change is a prereq for
>> a later one.
> Does it really matters here? This fix is quite generic, however, if you
> wish I can add relevant sentence which says so.

You should write the description in a way that it makes sense to anyone
reading it even without being aware of the details of later patches of
yours. Please always remember that patch series don't necessarily get
committed in one go - there may be weeks or even months between
this one going in and the other one following.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.