Re: [Xen-devel] [PATCH] xen:rtds: Update last_start whenever cur_budget is updated

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Oct 27, 2016 at 09:42:56AM -0400, Meng Xu wrote:
> Sorry, I accidentally sent out the previous email...
> 
> On Thu, Oct 27, 2016 at 6:03 AM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > On Thu, Oct 27, 2016 at 11:14:36AM +0200, Dario Faggioli wrote:
> >> On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote:
> >> > We keep last_start updated whenever cur_budget is updated.
> >> > This avoids subtle bugs in case burn_budget() will be called
> >> > in other places in the future.
> >> >
> >> I'd change this into something like:
> >>
> >> "Make budget accounting code more consistent by making sure the values
> >> used to compute how much budget has been consumed are updated together.
> >>
> >> This makes code resilient to calling burn_budget() from more than just
> >> one place --in case we will need to do that-- without risking subtle
> >> bugs."
> >>
> 
> Agree.
> 
> >> Also, when that is the case, like here, you need to explicitly state
> >> that no functional changes are intended.
> 
> As Dario suggested, it's better to add one more line in the change log
> "No functional changes are intended."
> 
> >>
> >> With all this done to the changelog:
> >>
> >> > Signed-off-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
> >> >
> >> Acked-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> >>
> >> This can go in 4.8, but can also well wait for 4.9.
> 
> Agree..
> 
> >>
> >
> > Meng, let me know if you're OK with Dario's suggestion.
> 
> I'm OK with his suggestion.
> I can send out a new patch with the new commit change log, if needed.
> 

No need. I will fix it up.

Wei.

> Thanks,
> 
> Meng
> 
> -- 
> ------------
> Meng Xu
> PhD Student in Computer and Information Science
> University of Pennsylvania
> http://www.cis.upenn.edu/~mengxu/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel