[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v6 02/11] locking/osq: Drop the overload of osq_lock()
- To: Pan Xinhui <xinhui.pan@xxxxxxxxxxxxxxxxxx>
- From: Davidlohr Bueso <dave@xxxxxxxxxxxx>
- Date: Sat, 29 Oct 2016 09:52:16 -0700
- Cc: kvm@xxxxxxxxxxxxxxx, rkrcmar@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, bsingharora@xxxxxxxxx, will.deacon@xxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx, kernellwp@xxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, xen-devel-request@xxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, borntraeger@xxxxxxxxxx, mingo@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, paulmck@xxxxxxxxxxxxxxxxxx, boqun.feng@xxxxxxxxx, jgross@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, David.Laight@xxxxxxxxxx, mpe@xxxxxxxxxxxxxx, pbonzini@xxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx
- Delivery-date: Sat, 29 Oct 2016 16:53:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, 28 Oct 2016, Pan Xinhui wrote:
/*
* If we need to reschedule bail... so we can block.
+ * Use vcpu_is_preempted to detech lock holder preemption issue
^^ detect
+ * and break.
Could you please remove the rest of this comment? Its just noise to point out
that vcpu_is_preempted is a macro defined by arch/false. This is standard
protocol
in the kernel.
Same goes for all locks you change with this.
Thanks,
Davidlohr
* vcpu_is_preempted is a macro defined by false if
+ * arch does not support vcpu preempted check,
*/
- if (need_resched())
+ if (need_resched() || vcpu_is_preempted(node_cpu(node->prev)))
goto unqueue;
cpu_relax_lowlatency();
--
2.4.11
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
