[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 02/11] locking/osq: Drop the overload of osq_lock()





在 2016/10/30 00:52, Davidlohr Bueso 写道:
On Fri, 28 Oct 2016, Pan Xinhui wrote:
        /*
         * If we need to reschedule bail... so we can block.
+         * Use vcpu_is_preempted to detech lock holder preemption issue
                                           ^^ detect
ok. thanks for poingting it out.
+         * and break.

Could you please remove the rest of this comment? Its just noise to point out
that vcpu_is_preempted is a macro defined by arch/false. This is standard 
protocol
in the kernel.

fair enough.

Same goes for all locks you change with this.

Thanks,
Davidlohr

               * vcpu_is_preempted is a macro defined by false if
+         * arch does not support vcpu preempted check,
         */
-        if (need_resched())
+        if (need_resched() || vcpu_is_preempted(node_cpu(node->prev)))
            goto unqueue;

        cpu_relax_lowlatency();
--
2.4.11




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.