Re: [Xen-devel] per-domain logging

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Nov 09, 2016 at 11:27:34AM +0100, Cedric Bosdonnat wrote:
> Hi Wei, Ian,
> 
> I now have a big lot of changes to use the LOG*D family through the libxl 
> code.
> What should be the best way to submit that for review? I guess a giant commit
> won't be too easy to handle for review and maintenance, maybe I should have 
> one
> commit per changed file... any opinion on that?
> 

Please have the first patch to be the one adding the LOG*D family
macros.

I don't really have an opinion on how to organise the actual changes to
various files. I think I would be more interested in how you classify
different LOG macros  and decide which ones to switch to LOGD family.

If the changes are done mechanically using tool like spatch, please
add the relevant runes into command message.

> --
> Cedric
> 
> On Thu, 2016-10-13 at 10:41 +0100, Wei Liu wrote:
> > On Thu, Oct 13, 2016 at 11:28:21AM +0200, Cedric Bosdonnat wrote:
> > > Hi Wei, Ian,
> > > 
> > > In quite a number of places, the domid we have in the function calling 
> > > LOG*
> > > may be the one of a stubdom. In the log we want to output the domid of the
> > > domain the user knows about. Would there be a way to get it?
> > > 
> > > An example of that is do_pci_add. It has a libxl_is_stubdom call, 
> > > suggesting
> > > that domid may not be the real domain id. An I wonder if there are other
> > > places where domid may be the one of a stubdom and I don't know it.
> > > 
> > 
> > The third argument of libxl_is_stubdom can be used to retrieve the
> > target domid.
> > 
> > If you find other places where you need to get the domid, please let me
> > know. I believe there are some fields embedded in various structs that
> > we can interrogate.
> > 
> > Wei.
> > 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel