Re: [Xen-devel] [PATCH 04/35] libxl.c: switch to LOG*D use

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Nov 15, 2016 at 11:18:42AM +0100, Cédric Bosdonnat wrote:
> Use LOG*D functions to output the domain ID in logs as much as
> possible. This will help consumer code sorting the logs by
> domain.
> 
> This commit includes all LOG* to LOG*D changes where the domain
> ID is not just a domid variable. We want the domain ID provided
> to the LOG*D functions to be the one of the publicly known
> domain, not a stubdom one.
> 
> Signed-off-by: Cédric Bosdonnat <cbosdonnat@xxxxxxxx>

I skimmed through the rest of this series. The code looks good to me.

The only thing I don't understand is why you had patch 2-4 for libxl.c.
These three patches can probably be merged into one patch.

Another thing is the From: field email address differs from patch to
patch. That's probably ok to you, but I think I should point that out in
case SuSE require you to always use your @suse.com address to
contribute.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel