[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] tools/libacpi: set FADT boot flag to notify lack of VGA for PVHv2 guests
On 12/01/2016 08:29 AM, Roger Pau Monne wrote: On Thu, Dec 01, 2016 at 06:09:09AM -0700, Jan Beulich wrote:On 01.12.16 at 13:40, <roger.pau@xxxxxxxxxx> wrote:PVHv2 guests don't have any VGA card, and as so it must be notified in the FADT. Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> Looking at this ...--- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -229,6 +229,7 @@ struct acpi_20_fadt { */ #define ACPI_LEGACY_DEVICES (1 << 0) #define ACPI_8042 (1 << 1) +#define ACPI_FADT_NO_VGA (1 << 2)... though makes me wonder: Don't we need a similar patch then for ACPI_FADT_NO_CMOS_RTC, the setting of which then would need to be in sync with XEN_X86_EMU_RTC? This will also eliminate the need in Linux to explicitly disable RTC for PVH guests. With ACPI_FADT_NO_CMOS_RTC this will be taken care of by generic ACPI boot code. -boris Right... and we also need to remove ACPI_8042, which is set by default. Will prepare two more patches to fix this. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |